RE: [PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC
From: Zulkifli, Muhammad Husaini
Date: Tue Jan 19 2021 - 23:27:21 EST
>From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>Sent: Tuesday, January 19, 2021 9:43 PM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx>
>Cc: Mark Brown <broonie@xxxxxxxxxx>; Liam Girdwood
><lgirdwood@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; DTML
><devicetree@xxxxxxxxxxxxxxx>; Hunter, Adrian <adrian.hunter@xxxxxxxxx>;
>Michal Simek <michal.simek@xxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; Linux
>Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Shevchenko, Andriy
><andriy.shevchenko@xxxxxxxxx>; A, Rashmi <rashmi.a@xxxxxxxxx>; Vaidya,
>Mahesh R <mahesh.r.vaidya@xxxxxxxxx>
>Subject: Re: [PATCH v1 0/9] mmc: sdhci-of-arasan: Add UHS-1 support for
>Keem Bay SOC
>On Thu, 14 Jan 2021 at 16:28, Muhammad Husaini Zulkifli
>> This patch series adds Ultra High Speed(UHS-1) Bus Speed Mode Support
>for Keem Bay SoC SD Card.
>> Summary of each patches as per below:
>> Patch 1: Use of_device_get_match_data() helper to get the match-data.
>> Patch 2: Convert to use np pointer instead of using pdev->dev.of_node.
>> Patch 3: Add struct device *dev in probe func(), so that dev pointer can be
>widely use in probe to make code more readable.
>> Patch 4: Change from dev_err to dev_err_probe() to avoid spamming logs
>when probe is deferred.
>> Patch 5: Export function to be use by device driver to configure i/o voltage
>rail output which communicate with Trusted Firmware.
>> Patch 6: Update phy and regulator supply for Keem Bay SoC.
>> Patch 7: Add DT Binding for Keem Bay SoC SD Regulator.
>> Patch 8: Add SD Regulator driver to support Keem Bay SoC. This is to
>> model using standard regulator abstraction during voltage operation as for
>Keem Bay SoC, i/o voltage rail need to be configure by setting specific bit in
>the AON_CFG1 Register.
>> AON_CFG1 Register is a secure register. Direct access to AON_CFG1 register
>will cause firewall violation in secure system.
>> Patch 9: Add Ultra High Speed (UHS-1) Support for Keem Bay SOC. For
>Keem Bay hardware, two regulators are been used to change the I/O bus line
>voltage which are "vqmmc-supply" and "sdvrail-supply".
>> All of these patches was tested with Keem Bay evaluation module board.
>> Kindly help to review this patch set.
>> Muhammad Husaini Zulkifli (9):
>> mmc: sdhci-of-arasan: use of_device_get_match_data()
>> mmc: sdhci-of-arasan: Convert to use np instead of pdev->dev.of_node
>> mmc: sdhci-of-arasan: Add structure device pointer in probe function
>> mmc: sdhci-of-arasan: Use dev_err_probe() to avoid spamming logs
>> firmware: keembay: Add support for Trusted Firmware Service call
>> dt-bindings: mmc: Update phy and regulator supply for Keem Bay SOC
>> dt-bindings: regulator: keembay: Add DT binding documentation
>> regulator: keembay: Add regulator for Keem Bay SoC
>> mmc: sdhci-of-arasan: Add UHS-1 support for Keem Bay SOC
>> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 7 +-
>> .../bindings/regulator/keembay-regulator.yaml | 36 ++
>> drivers/mmc/host/sdhci-of-arasan.c | 313 ++++++++++++++++--
>> drivers/regulator/Kconfig | 10 +
>> drivers/regulator/Makefile | 1 +
>> drivers/regulator/keembay-sd-regulator.c | 112 +++++++
>> include/linux/firmware/intel/keembay.h | 82 +++++
>> 7 files changed, 532 insertions(+), 29 deletions(-) create mode
>> create mode 100644 drivers/regulator/keembay-sd-regulator.c
>> create mode 100644 include/linux/firmware/intel/keembay.h
>Applied patch 1 to patch 4. I assume you will be respinning the rest?
Thanks!! Yeah. Seems like I need to request to ATF Team to implement SCMI voltage domain
control first in ARM trusted firmware.
>Thanks and kind regards