Re: [PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap

From: Rob Herring
Date: Wed Jan 20 2021 - 10:58:41 EST


On Fri, 15 Jan 2021 14:36:15 -0800, Philip Chen wrote:
> In Chrome OS, the keyboard matrix can be split to two groups:
>
> The keymap for the top row keys can be customized based on OEM
> preference, while the keymap for the other keys is generic/fixed
> across boards.
>
> This patch creates marcos for the keymaps of these two groups, making
> it easier to reuse the generic portion of keymap when we override the
> keymap in the board-specific dts for custom top row design.
>
> Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP
>
> include/dt-bindings/input/cros-ec-keyboard.h | 103 +++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 include/dt-bindings/input/cros-ec-keyboard.h
>


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.