Re: [PATCH 1/2] mfd: intel-m10-bmc: fix the register access range
From: Tom Rix
Date: Wed Jan 20 2021 - 12:32:02 EST
A side note..
I think it would be good if the intel-m10-bmc.* files were tracked in the MAINTAINERS files.
I was surprised the Lee was the only reviewer. Maybe Yilun or Matt should also be added.
On 1/19/21 6:34 PM, Xu Yilun wrote:
> This patch fixes the max register address of MAX 10 BMC. The range
> 0x20000000 ~ 0x200000fc are for control registers of the QSPI flash
> controller, which are not accessible to host.
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> include/linux/mfd/intel-m10-bmc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index c8ef2f1..06da62c 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -11,7 +11,7 @@
> #define M10BMC_LEGACY_SYS_BASE 0x300400
> #define M10BMC_SYS_BASE 0x300800
> -#define M10BMC_MEM_END 0x200000fc
> +#define M10BMC_MEM_END 0x1fffffff
Reviewed-by: Tom Rix <trix@xxxxxxxxxx>
> /* Register offset of system registers */
> #define NIOS2_FW_VERSION 0x0