Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

From: Michael Walle
Date: Wed Jan 20 2021 - 14:28:07 EST

Am 2021-01-20 20:02, schrieb Saravana Kannan:
On Wed, Jan 20, 2021 at 6:24 AM Rob Herring <robh@xxxxxxxxxx> wrote:

On Wed, Jan 20, 2021 at 4:53 AM Michael Walle <michael@xxxxxxxx> wrote:
> fw_devlink will defer the probe until all suppliers are ready. We can't
> use builtin_platform_driver_probe() because it doesn't retry after probe
> deferral. Convert it to builtin_platform_driver().

If builtin_platform_driver_probe() doesn't work with fw_devlink, then
shouldn't it be fixed or removed?

I was actually thinking about this too. The problem with fixing
builtin_platform_driver_probe() to behave like
builtin_platform_driver() is that these probe functions could be
marked with __init. But there are also only 20 instances of
builtin_platform_driver_probe() in the kernel:
$ git grep ^builtin_platform_driver_probe | wc -l

So it might be easier to just fix them to not use


Any chance you'd be willing to help me by converting all these to
builtin_platform_driver() and delete builtin_platform_driver_probe()?

If it just moving the probe function to the _driver struct and
remove the __init annotations. I could look into that.