Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

[Heikki Krogerus]

On Wed, Jan 20, 2021 at 06:17:35PM +0100, Greg KH wrote:
> On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote:
> > Hi,
> > 
> > On 1/14/21 3:50 PM, Kyle Tso wrote:
> > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@xxxxxxxxxx
> > > 
> > > "usb: typec: tcpm: AMS and Collision Avoidance"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - added FR_SWAP AMS handling
> > > 
> > > "usb: typec: tcpm: Protocol Error handling"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - modified more coding style problems (line wrapping limit)
> > > 
> > > "usb: typec: tcpm: Respond Wait if VDM state machine is running"
> > >  - no change
> > 
> > I've finally gotten around to testing this. I'm happy to
> > report that the power-role swapping regression seen in one
> > of the older versions of this patch-set is gone.
> > 
> > So the entire series is:
> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> 
> Thanks for testing and the review.
> 
> Heikki, any thoughts?

Looks good to me.

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

-- 
heikki