Re: [PATCH v3] ARM: tegra: ouya: Fix eMMC on specific bootloaders

From: Thierry Reding
Date: Thu Jan 21 2021 - 10:12:32 EST


On Thu, Jan 07, 2021 at 04:56:59PM +0000, Peter Geis wrote:
> Ouya fails to detect the eMMC module when booted via certain bootloaders.
> Fastboot and hard-kexec bootloaders fail while u-boot does not. It was
> discovered that the issue manifests if the sdmmc4 alternate configuration
> clock pin is input disabled.
>
> Ouya uses sdmmc4 in the primary pin configuration. It is unknown why this
> occurs, though it is likely related to other eMMC limitations experienced
> on Ouya.
>
> For now, fix it by enabling input on cam_mclk_pcc0.
>
> Fixes: d7195ac5c9c5 ("ARM: tegra: Add device-tree for Ouya")
> Reported-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx>
> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx>
> Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
> ---
> Changes v3:
> Removed stable tag, applies to v5.11+ only
>
> Changes v2:
> -Added stable tag.
> -Improved commit message.
>
> arch/arm/boot/dts/tegra30-ouya.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Arnd, Olof,

can you guys pick this up directly for v5.11, since I don't currently
have any other fixes queued up?

Here's a patchwork link:

http://patchwork.ozlabs.org/project/linux-tegra/patch/20210107165658.1354191-1-pgwipeout@xxxxxxxxx/

Thanks,
Thierry

> diff --git a/arch/arm/boot/dts/tegra30-ouya.dts b/arch/arm/boot/dts/tegra30-ouya.dts
> index 74da1360d297..0368b3b816ef 100644
> --- a/arch/arm/boot/dts/tegra30-ouya.dts
> +++ b/arch/arm/boot/dts/tegra30-ouya.dts
> @@ -4352,8 +4352,8 @@ cam_mclk_pcc0 {
> nvidia,pins = "cam_mclk_pcc0";
> nvidia,function = "vi_alt3";
> nvidia,pull = <TEGRA_PIN_PULL_NONE>;
> - nvidia,tristate = <TEGRA_PIN_ENABLE>;
> - nvidia,enable-input = <TEGRA_PIN_DISABLE>;
> + nvidia,tristate = <TEGRA_PIN_DISABLE>;
> + nvidia,enable-input = <TEGRA_PIN_ENABLE>;
> };
> pcc1 {
> nvidia,pins = "pcc1";
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature