Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver.

From: Mohamed Mediouni
Date: Thu Jan 21 2021 - 10:24:03 EST




> On 21 Jan 2021, at 16:09, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> On Thu, Jan 21, 2021 at 3:10 PM Marc Zyngier <maz@xxxxxxxxxx> wrote:
>> On 2021-01-21 13:34, Mohamed Mediouni wrote:
>>>> On 21 Jan 2021, at 14:22, Marc Zyngier <maz@xxxxxxxxxx> wrote:
>>> Because UART access adapters for the new M1 Macs aren’t plentiful
>>> at all, I actually use this for development, with iPhones which have
>>> much more easy to buy Lightning-to-UART adapters.
>>>
>>> (That’s why the old implementation is there too)
>>>
>>> Might be worth splitting the new one to a new commit though...
>>
>> This series is supposed to cover M1 only, and adding extra support
>> as part of it is only likely to make the code harder to review.
>>
>> I'd rather you focus on a single IPI interface (fast or slow,
>> I don't really care). Extra features can come in later.
>
> Agreed. The slow interface is probably easier to start with,
> because it avoids hooking into the FIQ, so the FIQ can be
> completely decoupled from AIC and just used for the timer.
>
> Maybe there is even a way to use more than one hardware IPI in
> the AIC?
>
> Arnd
Hello,

Decided to only have only the slow interface in the second patch series.

Thank you,