Re: [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding

From: Linus Walleij
Date: Thu Jan 21 2021 - 10:34:46 EST


On Wed, Jan 20, 2021 at 11:21 PM Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:

> Several properties are shared between all TLMM bindings. By providing a
> common binding to define these properties each platform's binding can be
> reduced to just listing which of these properties should be checked for
> - or further specified.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Overall it looks good, just cutting some slack for reviewers (especially
DT people) before applying.

> +description:
> + This defines the common properties used to describe all Qualcomm TLMM
> + bindings and pinconf/pinmux states for these.

I vaguely recall asking you in the past what the acronym TLMM actually
means. This would be a good place to expand the acronym so people
know what these four letters actually represent.

(There, I finally gave you an official reason to go and poke Qualcomm
hardware engineers about this. ;)

Yours,
Linus Walleij