Re: Splicing to/from a tty

From: Robert Karszniewicz
Date: Thu Jan 21 2021 - 12:36:50 EST


On 1/20/21 5:44 AM, Linus Torvalds wrote:
> On Tue, Jan 19, 2021 at 5:29 PM Oliver Giles <ohw.giles@xxxxxxxxx> wrote:
>>
>> Writing this from a kernel with those patches in; happily splice()ing
>> to and from a pty.
>
> Ok, good.
>
> I have a couple of improvement patches on top of those, that I'm attaching here.
>
> [...]
>
> But in the meantime, here's two more patches to try on top of the
> previous four. They shouldn't matter, other than making the non-icanon
> throughput a lot better. But the more coverage they get, the happier
> I'll be.

I confirm that the 4 patches, as well as the 4+2 patches, fix the regression I
noticed with cat failing on sendfile() to ttymxc0.

Thanks,
Robert