Re: [PATCH 3/3] libnvdimm/ioctl: Switch to cdev_register_queued()

From: Dan Williams
Date: Thu Jan 21 2021 - 12:40:15 EST

On Thu, Jan 21, 2021 at 12:16 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Jan 20, 2021 at 11:39:08AM -0800, Dan Williams wrote:
> > The ioctl implementation in libnvdimm is a case study in what can be
> > cleaned up when the cdev core handles synchronizing in-flight ioctls
> > with device removal. Switch to cdev_register_queued() which allows for
> > the ugly context lookup and activity tracking implementation to be
> > dropped, among other cleanups.
> I'm confused, the cdev handles the filesystem access from /dev/ which
> handles the ioctl. Any use of a cdev with relationship to a struct
> device that might go away is independent, so we really should not tie
> these together in any way.

Oh, no, there's no object lifetime ties here, that problem was already
solved with Logan's addition of cdev_device_add(). Instead, this about
file_operations liveness. Look at procfs and debugfs that Christoph
pointed out have open coded the same facility. When the driver is
unbound ongoing file operations should be flushed and blocked
currently the cdev api is forcing every driver to open code this

This seems a pattern that is asking to be unified as a general
"managed fops" concept.