Re: [PATCH] ACPICA: fix -Wfallthrough
From: Rafael J. Wysocki
Date: Thu Jan 21 2021 - 14:08:39 EST
On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
> On 11/11/2020 02:11, Nick Desaulniers wrote:
> > The "fallthrough" pseudo-keyword was added as a portable way to denote
> > intentional fallthrough. This code seemed to be using a mix of
> > fallthrough comments that GCC recognizes, and some kind of lint marker.
> > I'm guessing that linter hasn't been run in a while from the mixed use
> > of the marker vs comments.
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> I know this is not the exact version that was merged, I can't find it on
> the list, but looks like the version that was merged ,
It would be this patch:
> is causing build errors with older toolchains (GCC v6) ...
> /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function ‘acpi_ds_exec_begin_control_op’:
> /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error: ‘ACPI_FALLTHROUGH’ undeclared (first use in this function)
> /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each undeclared identifier is reported only once for each function it appears in
> /dvs/git/dirty/git-master_l4t-upstream/kernel/scripts/Makefile.build:287: recipe for target 'drivers/acpi/acpica/dscontrol.o' failed
>  https://github.com/acpica/acpica/commit/4b9135f5