Re: [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay

From: Viresh Kumar
Date: Thu Jan 21 2021 - 15:38:05 EST


On 21-01-21, 17:34, David Gibson wrote:
> No, this is the wrong way around. The expected operation here is that
> you apply overlay (1) to the base tree, giving you, say, output1.dtb.
> output1.dtb is (effectively) a base tree itself, to which you can then
> apply overlay-(2).

Thanks for the confirmation about this.

> Merging overlays is
> something that could make sense, but fdtoverlay will not do it at
> present.

FWIW, I think it works fine right now even if it not intentional. I
did inspect the output dtb (made by merging two overlays) using
fdtdump and it looked okay. But yeah, I understand that we shouldn't
do it.

--
viresh