Re: [PATCH 3/6] devicetree/bindings: Initial commit of silergy,sy7636a-regulator.yaml
From: Alistair Francis
Date: Fri Jan 22 2021 - 00:10:04 EST
On Mon, Jan 18, 2021 at 4:42 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, Jan 18, 2021 at 12:35:19PM +0000, Mark Brown wrote:
> > On Sat, Jan 16, 2021 at 08:25:36PM -0800, Alistair Francis wrote:
>
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - sy7636a-regulator
>
> > Compatible strings should be in the form vendor,device.
>
> You should not have separate binding documents for MFD subfunctions that
> don't have separate compatible strings in DT, include the documentation
> for the properties used by those subfunctions in the main MFD binding
> document.
Thanks for the review. I have updated the patch and will send a v2.
Alistair