Re: [PATCH] uacce: Add uacce_ctrl misc device

From: Greg Kroah-Hartman
Date: Fri Jan 22 2021 - 06:41:57 EST


On Fri, Jan 22, 2021 at 07:33:40PM +0800, Zhou Wang wrote:
> >> +struct uacce_pin_address {
> >> + unsigned long addr;
> >> + unsigned long size;
> >
> > These are not valid ioctl structure members for crossing the user/kernel
> > boundry. Please make them work properly (i.e. use __u64 and friends).
>
> Got it, will modify this to __u64 together with other problems found by 0-day robot.

Please also properly involve the mm and dma developers and, again,
consider just making this a syscall instead of an ioctl.

thanks,

greg k-h