Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra

[Daniel Walker (danielwa)]

On Fri, Jan 22, 2021 at 09:48:53AM +0100, Michal Simek wrote:
> Hi Daniel,
> 
> On 1/22/21 12:12 AM, Daniel Walker wrote:
> > Add Petra and Hellcat dts file. These platforms are based on
> > the Xilinx Zynqmp platform.
> > 
> > Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx>
> > Cc: xe-linux-external@xxxxxxxxx
> > ---
> >  arch/arm64/boot/dts/xilinx/Makefile           |   2 +
> >  .../boot/dts/xilinx/zynqmp-petra-hellcat.dts  | 856 ++++++++++++++++++
> >  arch/arm64/boot/dts/xilinx/zynqmp-petra.dts   | 847 +++++++++++++++++
> >  3 files changed, 1705 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra-hellcat.dts
> >  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-petra.dts
> 
> First of all I can't see 2/2.
 
It wasn't being submitted to you. But here it is if you care to look at it.

https://lkml.org/lkml/2021/1/21/1468

> 
> Long time ago we said that we are not going to push any PL related
> configurations. It means all below can't be merged.
> And there are also coding style issues.

You'll need to explain this more. It's likely this was added at the suggestion of
Xilinx. If it can't be upstreamed what should we replace it with ?

I will review your other comments and re-submit.

Daniel