Re: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64

From: Jens Axboe
Date: Sat Jan 23 2021 - 18:34:49 EST


On 1/23/21 4:27 PM, Matthew Wilcox wrote:
> On Sat, Jan 23, 2021 at 01:41:52PM +0200, Lennert Buytenhek wrote:
>> IORING_OP_GETDENTS64 behaves like getdents64(2) and takes the same
>
> Could we drop the '64'? We don't, for example, have IOURING_OP_FADVISE64
> even though that's the name of the syscall.

Agreed, only case we do mimic the names are for things like
IORING_OP_OPENAT2 where it does carry meaning. For this one, it should
just be IORING_OP_GETDENTS.

--
Jens Axboe