Re: [PATCH v6 1/4] usb: gadget: udc: core: Introduce check_config to verify USB configuration

From: Wesley Cheng
Date: Tue Jan 26 2021 - 05:20:01 EST




On 1/21/2021 9:17 PM, Jack Pham wrote:
> Hi Wesley,
>
> On Thu, Jan 21, 2021 at 08:01:37PM -0800, Wesley Cheng wrote:
>> Some UDCs may have constraints on how many high bandwidth endpoints it can
>> support in a certain configuration. This API allows for the composite
>> driver to pass down the total number of endpoints to the UDC so it can verify
>> it has the required resources to support the configuration.
>>
>> Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx>
>> ---
>> drivers/usb/gadget/udc/core.c | 9 +++++++++
>> include/linux/usb/gadget.h | 2 ++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
>> index 4173acd..469962f 100644
>> --- a/drivers/usb/gadget/udc/core.c
>> +++ b/drivers/usb/gadget/udc/core.c
>> @@ -1003,6 +1003,15 @@ int usb_gadget_ep_match_desc(struct usb_gadget *gadget,
>> }
>> EXPORT_SYMBOL_GPL(usb_gadget_ep_match_desc);
>>
>> +int usb_gadget_check_config(struct usb_gadget *gadget, unsigned long ep_map)
>
> You should probably add a kernel-doc for this function.
>
> Jack
>
Hi Jack,

Sure, I'll update a bit more about how this API can be used.

Thanks
Wesley Cheng

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project