Re: [PATCH v10 2/4] arm64: dts: mt8183: Add node for the Mali GPU

From: Nicolas Boichat
Date: Tue Jan 26 2021 - 05:35:31 EST


On Tue, Jan 26, 2021 at 3:27 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
[...]
> > +&gpu {
> > + supply-names = "mali", "sram";
>
> Not a documented property, nor should it be.
>
> Did you run this against dtbs_check with your schema changes?

I did not, for some reasons I hit a strange issue (kernel build system
wouldn't pick up dt-* tools from ~/.local/bin... solved with a bunch
of symlinks to ~/bin). Gave up too quickly ,-(

Anyway, v11 coming with clean make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml.

>
> > + mali-supply = <&mt6358_vgpu_reg>;
> > + sram-supply = <&mt6358_vsram_gpu_reg>;
> > +};
> > +
> > &i2c0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&i2c_pins_0>;