RE: [PATCH] Bluetooth: hci_h5: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for btrtl

From: Hilda Wu
Date: Tue Jan 26 2021 - 16:30:56 EST


Thanks Claire. Patch looks good to me.

Reviewed-by: Hilda Wu <hildawu@xxxxxxxxxxx>

-----Original Message-----
From: Claire Chang <tientzu@xxxxxxxxxxxx>
Sent: Tuesday, January 19, 2021 7:47 PM
To: marcel@xxxxxxxxxxxx; johan.hedberg@xxxxxxxxx; luiz.dentz@xxxxxxxxx
Cc: linux-bluetooth@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Max Chou <max.chou@xxxxxxxxxxx>; Hilda Wu <hildawu@xxxxxxxxxxx>; Claire Chang <tientzu@xxxxxxxxxxxx>
Subject: [PATCH] Bluetooth: hci_h5: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for btrtl

Realtek Bluetooth controllers can do both LE scan and BR/EDR inquiry at once, need to set HCI_QUIRK_SIMULTANEOUS_DISCOVERY quirk.

Signed-off-by: Claire Chang <tientzu@xxxxxxxxxxxx>
---
drivers/bluetooth/hci_h5.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c index fb9817f97d45..27e96681d583 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -906,6 +906,11 @@ static int h5_btrtl_setup(struct h5 *h5)
/* Give the device some time before the hci-core sends it a reset */
usleep_range(10000, 20000);

+ /* Enable controller to do both LE scan and BR/EDR inquiry
+ * simultaneously.
+ */
+ set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &h5->hu->hdev->quirks);
+
out_free:
btrtl_free(btrtl_dev);

--
2.30.0.284.gd98b1dd5eaa7-goog