Re: Thoughts on sharing KVM tracepoints [was:Re: [PATCH 2/2] KVM: nVMX: trace nested vm entry]

[Paolo Bonzini]

On 25/01/21 22:01, Sean Christopherson wrote:
> I 100% think that VMX and SVM should share the bulk of the
> code.  Improvements to VMX almost always apply in some way to SVM, and vice
> versa.

I agree.

> IMO, after debugging a few times, associating
> error_code with the event being injected is second nature.  Prepending
> intr_info_ would just add extra characters and slow down mental processing.
>
> > of course both it and intr_info are VMX specific).
>
> Not really, SVM has the exact same fields with slightly different names.

I slightly prefer the SVM names, using eventinj and eventinjerr in the 
trace points wouldn't be bad.

Having too many tracepoints are a problem.  Having a lot of info in a 
single tracepoint is not a problem, though.

Paolo