Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

[Tom Hebb]

On Wed, Jan 27, 2021 at 2:58 PM Pali Rohár <pali@xxxxxxxxxx> wrote:
>
> Hello Bob!
>
> On Thursday 28 January 2021 08:40:36 Bob Hepple wrote:
> > Hi Pali,
> >
> > No, I have not contacted Dell about this and I'm not sure that they
> > would be terribly interested given that my machine is 12 years old -
> > but I'll have a go if I can find the right place to do it.
>
> If it is 12 years old machine then I doubt that anybody would do any
> support for it...
>
> > Do you have a good email or other Dell target to report it?
>
> In this post is information how to contact Dell Linux support team which
> can open (internal) BIOS issue:
>
> https://github.com/dell/libsmbios/issues/48#issuecomment-391328501
>
> But it is possible that still only available for USA.
>
> Mario (superm1 on github) is active also in kernel and can help with
> firmware issues on new machines.
>
> But for this your 12 years old machine is proposed blacklist quirk the
> only option.
>
> I just do not know if this issue was already fixed in new BIOS which is
> available on new machines. And therefore I'm worried if these issues
> would continue to appear also on other machines, or we are just
> collecting list of old machines.

My XPS 13 9350 from 2015 does not exhibit this issue, FWIW. I think we
would be seeing a lot more reports like this if new BIOSes were also
affected.


> Just I do not want to see situation when manufacture says "it is
> working, nothing needed to fix" and it would work just because of
> blacklist... As such scenario would lead only to increasing blacklist
> without ability to start fixing issues.
>
> > I don't
> > have access to official Dell support as my warranty ran out about 10
> > years ago. Perhaps there's an existing Dell bug report that references
> > the original https://bugzilla.kernel.org/show_bug.cgi?id=195751 ??? I
> > could add my report there if someone has already informed Dell about
> > the other instances of the bug.
> >
> > Thanks
> >
> >
> >
> > Bob
> >
> > On Wed, 27 Jan 2021 at 19:19, Pali Rohár <pali@xxxxxxxxxx> wrote:
> > >
> > > On Tuesday 26 January 2021 00:15:13 Tom Hebb wrote:
> > > > Bob reports that blacklisting the fan type label is not sufficient.
> > > > See his message to me below.
> > >
> > > Ok! Thank you for confirmation.
> > >
> > > And my second question which I have asked:
> > > And have you reported this issue to Dell support?
> > >
> > > > On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@xxxxxxxxx> wrote:
> > > > >
> > > > > Hi Tom,
> > > > >
> > > > > Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
> > > > >
> > > > > Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> > > > > isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
> > > > >
> > > > > ... and lots of trackpad stall/stutters.
> > > > >
> > > > > Cheers
> > > > >
> > > > >
> > > > > Bob
> > > > >
> > > > >
> > > > >
> > > > > On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@xxxxxxxxx> wrote:
> > > > > >
> > > > > > ... compiling now ... results in a coupla hours
> > > > > >
> > > > > > Cheers
> > > > > >
> > > > > >
> > > > > > Bob
> > > > > >
> > > > > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@xxxxxxxxx> wrote:
> > > > > > >
> > > > > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@xxxxxxxxxx> wrote:
> > > > > > > >
> > > > > > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > > > > > was exposed by a prior change of mine to automatically load
> > > > > > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > > > > > this model to the blacklist.
> > > > > > > > >
> > > > > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > > > > > >
> > > > > > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > > > > > Cc: stable@xxxxxxxxxxxxxxx
> > > > > > > > > Reported-by: Bob Hepple <bob.hepple@xxxxxxxxx>
> > > > > > > > > Tested-by: Bob Hepple <bob.hepple@xxxxxxxxx>
> > > > > > > > > Signed-off-by: Thomas Hebb <tommyhebb@xxxxxxxxx>
> > > > > > > > > ---
> > > > > > > > >
> > > > > > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > > > > > >  1 file changed, 7 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > > > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > > > > > >               },
> > > > > > > > >       },
> > > > > > > > > +     {
> > > > > > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > > > > > +             .matches = {
> > > > > > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > > > > > >
> > > > > > > > Hello! Are you sure that it is required to completely disable fan
> > > > > > > > support? And not only access to fan type label for which is different
> > > > > > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > > > > >
> > > > > > > This is a good question. We didn't try the other list. Bob is the one with the
> > > > > > > affected system. Could you try moving the added block of code from
> > > > > > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > > > > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > > > > > remains fixed?
> > > > > > >
> > > > > > > >
> > > > > > > > And have you reported this issue to Dell support?
> > > > > > > >
> > > > > > > > > +             },
> > > > > > > > > +     },
> > > > > > > > >       { }
> > > > > > > > >  };
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > 2.30.0
> > > > > > > > >
> > > > > > >
> > > > > > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > > > > > >
> > > > > > > -Tom