Re: [PATCH] Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"

From: Masahiro Yamada
Date: Thu Jan 28 2021 - 01:40:59 EST


On Wed, Jan 27, 2021 at 12:02 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2021-01-27 at 04:15 +0900, Masahiro Yamada wrote:
> > This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.
> >
> > You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop
> > 'boolean' keyword").
> >
> > This check is no longer needed.
>

Applied to linux-kbuild.


> Thanks.
>
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>
> Acked-by: Joe Perches <joe@xxxxxxxxxxx>
>
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3390,13 +3390,6 @@ sub process {
> > }
> > }
> >
> > -# discourage the use of boolean for type definition attributes of Kconfig options
> > - if ($realfile =~ /Kconfig/ &&
> > - $line =~ /^\+\s*\bboolean\b/) {
> > - WARN("CONFIG_TYPE_BOOLEAN",
> > - "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> > - }
> > -
> > if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
> > ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
> > my $flag = $1;
>
>


--
Best Regards
Masahiro Yamada