Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
From: Sumit Garg
Date: Mon Feb 01 2021 - 00:04:34 EST
Hi Jens,
On Fri, 29 Jan 2021 at 18:59, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Hi Rouven and Sumit,
> >
> > On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
> > <jens.wiklander@xxxxxxxxxx> wrote:
> > >
> > > Testing need_resched() before cond_resched() is not needed as an
> > > equivalent test is done internally in cond_resched(). So drop the
> > > need_resched() test.
> > >
> > > Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
> > > Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
> > > ---
> > > drivers/tee/optee/call.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
It does work for me as well.
Tested-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
-Sumit
>
> Thanks,
> Jens