Re: [PATCH] serial: 8250: add option to disable registration of legacy ISA ports

From: Greg Kroah-Hartman
Date: Mon Feb 01 2021 - 02:39:47 EST


On Sun, Jan 31, 2021 at 09:25:33PM +0200, Andy Shevchenko wrote:
> On Thursday, January 28, 2021, Mans Rullgard <mans@xxxxxxxxx> wrote:
>
> > On systems that do not have the traditional PC ISA serial ports, the
> > 8250 driver still creates non-functional device nodes. This change
> > makes only ports that actually exist (PCI, DT, ...) get device nodes.
> >
> >
>
> This is kinda ABI breakage. At least this will break x86 platforms with
> HSUARTs (all modern ones) that are used in embedded systems.
>
> I think you would rather need an option to disable this and select it by
> the platforms where it is known not to break anything.

This option is behind CONFIG_EXPERT, if you set it, you know what you
are doing, so that's fine.

thanks,

greg k-h