Re: [PATCH v2 4/8] KVM: arm64: Generate hyp relocation data

From: Marc Zyngier
Date: Mon Feb 01 2021 - 07:08:45 EST


Hi David,

On 2021-02-01 10:42, David Brazdil wrote:
Thanks for writing the fix, Marc! There are no corner cases in this code so
if it boots, that should be a good indicator that all BE inputs were converted.

Just one little thing I noticed below, otherwise:
Acked-by: David Brazdil <dbrazdil@xxxxxxxxxx>

arch/arm64/kvm/hyp/nvhe/Makefile | 1 +
arch/arm64/kvm/hyp/nvhe/gen-hyprel.c | 57 ++++++++++++++++++++--------
2 files changed, 42 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
index 268be1376f74..09d04dd50eb8 100644
--- a/arch/arm64/kvm/hyp/nvhe/Makefile
+++ b/arch/arm64/kvm/hyp/nvhe/Makefile
@@ -7,6 +7,7 @@ asflags-y := -D__KVM_NVHE_HYPERVISOR__
ccflags-y := -D__KVM_NVHE_HYPERVISOR__

hostprogs := gen-hyprel
+HOST_EXTRACFLAGS += -I$(srctree)/include
This should be $(objtree), autoconf.h is generated.

Ah, well spotted. I build things in place, so it obviously never showed up.
Now fixed and pushed out with your Ack.

Thanks,

M.
--
Jazz is not dead. It just smells funny...