Re: [PATCH v3 4/5] x86/sgx: Allows ioctl PROVISION to execute before CREATE

[Tianjia Zhang]

On 1/30/21 9:26 PM, Jarkko Sakkinen wrote:
> On Sun, Jan 24, 2021 at 02:29:06PM +0800, Tianjia Zhang wrote:
> > In the function sgx_create_enclave(), the direct assignment
> > operation of attributes_mask determines that the ioctl PROVISION
> > operation must be executed after the ioctl CREATE operation,
> > which will limit the flexibility of sgx developers.
> >
> > This patch takes the assignment of `attributes_mask` from the
> > function sgx_create_enclave() has been moved to the function
> > sgx_open() to avoid this restriction.
> >
> > Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
>
> The commit message should explicit that the API behaviour changes
> as the result. Please don't use hyphens in quoting.
>
> /Jarkko

Will be improved in the next version.

Best regards,
Tianjia

> > ---
> >   arch/x86/kernel/cpu/sgx/driver.c | 1 +
> >   arch/x86/kernel/cpu/sgx/ioctl.c  | 1 -
> >   2 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/sgx/driver.c b/arch/x86/kernel/cpu/sgx/driver.c
> > index f2eac41bb4ff..fba0d0bfe976 100644
> > --- a/arch/x86/kernel/cpu/sgx/driver.c
> > +++ b/arch/x86/kernel/cpu/sgx/driver.c
> > @@ -36,6 +36,7 @@ static int sgx_open(struct inode *inode, struct file *file)
> >   		return ret;
> >   	}
> >   
> > +	encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | SGX_ATTR_KSS;
> >   	file->private_data = encl;
> >   
> >   	return 0;
> > diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c
> > index 90a5caf76939..1c6ecf9fbeff 100644
> > --- a/arch/x86/kernel/cpu/sgx/ioctl.c
> > +++ b/arch/x86/kernel/cpu/sgx/ioctl.c
> > @@ -109,7 +109,6 @@ static int sgx_encl_create(struct sgx_encl *encl, struct sgx_secs *secs)
> >   	encl->base = secs->base;
> >   	encl->size = secs->size;
> >   	encl->attributes = secs->attributes;
> > -	encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | SGX_ATTR_KSS;
> >   
> >   	/* Set only after completion, as encl->lock has not been taken. */
> >   	set_bit(SGX_ENCL_CREATED, &encl->flags);
> > --
> > 2.19.1.3.ge56e4f7