Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings

[Sakari Ailus]

On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote:
> Hi,
> 
> On Sat 16 Jan 21, 21:11, Julia Lawall wrote:
> > From: kernel test robot <lkp@xxxxxxxxx>
> > 
> > PTR_ERR should access the value just tested by IS_ERR
> 
> Good catch!
> 
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>

Thanks, Julia and Paul.

A patch with similar content got recently merged:

commit 6e7cca2790a54057ddf64da7843271e192f71ca0
Author: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
Date:   Wed Jan 20 09:42:38 2021 +0100

    media: i2c/ov8865.c: fix error checks using wrong variable
    
    Fix two typos: dvdd -> dovdd and dvdd -> avdd
    
    Both clearly copy-and-paste mistakes.
    
    Fixes this smatch warning:
    
    drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR'
    
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

-- 
Kind regards,

Sakari Ailus