Re: [PATCH 02/14] cxl/mem: Map memory device registers

[Konrad Rzeszutek Wilk]

>  
> -	return 0;
> +	rc = -ENXIO;
> +	for (i = regloc; i < regloc + 0x24; i += 8) {

This 0x24, 8, and
> +		u32 reg_lo, reg_hi;
> +		u8 reg_type;
> +
> +		/* "register low and high" contain other bits */
> +		pci_read_config_dword(pdev, i, &reg_lo);
> +		pci_read_config_dword(pdev, i + 4, &reg_hi);

4

scream of #define's or sizeof()?