Re: [PATCH v15 09/10] arm64: Call kmalloc() to allocate DTB buffer

From: Thiago Jung Bauermann
Date: Mon Feb 01 2021 - 14:02:28 EST



Joe Perches <joe@xxxxxxxxxxx> writes:

> On Thu, 2021-01-28 at 00:52 -0300, Thiago Jung Bauermann wrote:
>> The problem is that this patch implements only part of the suggestion,
>> which isn't useful in itself. So the patch series should either drop
>> this patch or consolidate the FDT allocation between the arches.
>>
>> I just tested on powernv and pseries platforms and powerpc can use
>> vmalloc for the FDT buffer.
>
> Perhaps more sensible to use kvmalloc/kvfree.

That's true. Converting both arm64 to powerpc to kvmalloc/kvfree is a
good option. I don't think it's that much better though, because
kexec_file_load() is called infrequently and doesn't need to be fast so
the vmalloc() overhead isn't important in practice.

--
Thiago Jung Bauermann
IBM Linux Technology Center