Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

[Russell King - ARM Linux admin]

On Mon, Feb 01, 2021 at 08:07:37PM +0000, Giancarlo Ferrari wrote:
> Hi,

Hi,

> Why we should align 3 ? For the fncpy I suppose.

Slightly arbitary really - it gives a nice 8-byte alignment to the data.
.align 2 would also be sufficient.

> I don't know now how to proceed now, as you (Mark and you) do completely
> the patch.

Please can you test my patch and let us know if it solves your problem
(or even if it works! I haven't tested it beyond build-testing.)

> You see is my first kernel patch submission :) .

Yay. Sorry for giving you a different patch - Mark is quite right that
there's a better solution to this problem, which is eliminating the
set_kernel_text_rw() call. The only reason I cooked up the patch was
doing that would be more in-depth (as you can see from the increased
size of the patch.)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!