Re: [Linaro-mm-sig] [PATCH 08/29] dma-buf: Avoid comma separated statements

[Christian König]

Yeah, known issue.

An NTP server which I don't have access to has gone bananas and 
sometimes spits out invalid time stamps.

Only thing I can do is wait for an admin to take care of this.

Christian.

Am 01.02.21 um 22:54 schrieb Lyude Paul:
> This is entirely unrelated to this thread, but I noticed when going through dri-
> devel that this email is somehow dated two days in the future from now.
>
> On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
> > Am 30.01.21 um 19:47 schrieb Joe Perches:
> > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > > > Use semicolons and braces.
> > > Ping?
> > >    
> > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > Reviewed-by: Christian König <christian.koenig@xxxxxxx>
> >
> > Do you have commit rights to drm-misc-next?
> >
> > > > ---
> > > >    drivers/dma-buf/st-dma-fence.c | 7 +++++--
> > > >    1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-
> > > > fence.c
> > > > index e593064341c8..c8a12d7ad71a 100644
> > > > --- a/drivers/dma-buf/st-dma-fence.c
> > > > +++ b/drivers/dma-buf/st-dma-fence.c
> > > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
> > > >                          dma_fence_signal(f1);
> > > >    
> > > >
> > > >                  smp_store_mb(cb.seen, false);
> > > > -               if (!f2 || dma_fence_add_callback(f2, &cb.cb,
> > > > simple_callback))
> > > > -                       miss++, cb.seen = true;
> > > > +               if (!f2 ||
> > > > +                   dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> > > > +                       miss++;
> > > > +                       cb.seen = true;
> > > > +               }
> > > >    
> > > >
> > > >                  if (!t->before)
> > > >                          dma_fence_signal(f1);
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel