RE: [PATCH v4 3/4] perf tools: Fix lexical definition of event name

From: nakamura.shun@xxxxxxxxxxx
Date: Tue Feb 02 2021 - 06:06:38 EST


(I missed to include the quotation in the text. Will resend. Sorry about that.)

Hi, John

> > Fix the lexical definition of event name so that the numbers are recognizable.
> >
> > A64FX defines an event name that starts with a number.
> > - 0inst_commit
> > - 1inst_commit
> > - 2inst_commit
> > - 3inst_commit
> > - 4inst_commit
> >
> > Signed-off-by: Shunsuke Nakamura <nakamura.shun@xxxxxxxxxxx>
>
> eh... I'm not sure if you will encounter other problems, so may be prudent to
> change the event name to not start with a number. Someone else may also advise
> on this.
I have applied this patch and confirmed that the event can be specified correctly.
Event names are defined in the A64FX specification.
I want to deal with it at that time if there is a problem.

So I would like to resend the v5 patch and wait for advice from others.

Best Regards
Shunsuke