RE: [PATCH 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

[Gustavo Pimentel]

On Mon, Feb 1, 2021 at 22:39:20, Bjorn Helgaas <helgaas@xxxxxxxxxx> 
wrote:

Hi Bjorn,

> > +/**
> > + * pci_find_vsec_capability - Find a vendor-specific extended capability
> > + * @dev: PCI device to query
> > + * @cap: vendor-specific capability id code
> 
> s/id/ID/

I will do it for all the requested changes.

> >  
> > +/* Vendor-Specific Extended Capabilities */
> > +#define PCI_VSEC_CAP_ID(header)		(header & 0x0000ffff)
> > +#define PCI_VSEC_CAP_REV(header)	((header >> 16) & 0xf)
> > +#define PCI_VSEC_CAP_LEN(header)	((header >> 20) & 0xffc)
> 
> Please put these next to the existing PCI_VSEC_HDR.

I will move it next to HDR. The 0xffc was a typo, thanks for noticing it.
About the PCI_VSEC_CAP_REV and PCI_VSEC_CAP_LEN macros, I will be using 
on dw_edma_pcie_get_vsec_dma_data() from dw-edma-pcie.c has a validation 
of the right DVSEC.

I will send a version 2 with those fixes.

-Gustavo