Re: [PATCH] dpaa2-eth: Simplify the calculation of variables

[Ioana Ciornei]

On Tue, Feb 02, 2021 at 06:02:37PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING
> !A || A && B is equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
Acked-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>

> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> index fb0bcd1..93f84c9 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -1648,7 +1648,7 @@ void dpaa2_eth_set_rx_taildrop(struct dpaa2_eth_priv *priv,
>  	 * CG taildrop threshold, so it won't interfere with it; we also
>  	 * want frames in non-PFC enabled traffic classes to be kept in check)
>  	 */
> -	td.enable = !tx_pause || (tx_pause && pfc);
> +	td.enable = !tx_pause || pfc;
>  	if (priv->rx_cgtd_enabled == td.enable)
>  		return;
>  
> -- 
> 1.8.3.1
>