Re: [net-next v2 07/14] octeontx2-pf: cn10k: Use LMTST lines for NPA/NIX operations

From: kernel test robot
Date: Tue Feb 02 2021 - 08:37:50 EST

Hi Geetha,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Add-Marvell-CN10K-support/20210202-140820
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6626a0266566c5aea16178c5e6cd7fc4db3f2f56
config: ia64-randconfig-r006-20210202 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2b6495d2b221c50facea4eb70bee5d0cccfb43e4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geetha-sowjanya/Add-Marvell-CN10K-support/20210202-140820
git checkout 2b6495d2b221c50facea4eb70bee5d0cccfb43e4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:21:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function '__cn10k_aura_freeptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:529:16: warning: variable 'val' set but not used [-Wunused-but-set-variable]
529 | u64 tar_addr, val = 0;
| ^~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_freeptr':
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:578:19: warning: unused variable 'pfvf' [-Wunused-variable]
578 | struct otx2_nic *pfvf = dev;
| ^~~~
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/cn10k.h:10,
from drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c:7:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function '__cn10k_aura_freeptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:529:16: warning: variable 'val' set but not used [-Wunused-but-set-variable]
529 | u64 tar_addr, val = 0;
| ^~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_freeptr':
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:578:19: warning: unused variable 'pfvf' [-Wunused-variable]
578 | struct otx2_nic *pfvf = dev;
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c: In function 'cn10k_sqe_flush':
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c:164:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
164 | u64 val = 0, tar_addr = 0;
| ^~~


vim +/val +529 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h

523
524 static inline void __cn10k_aura_freeptr(struct otx2_nic *pfvf, u64 aura,
525 u64 *ptrs, u64 num_ptrs,
526 u64 *lmt_addr)
527 {
528 u64 size = 0, count_eot = 0;
> 529 u64 tar_addr, val = 0;
530
531 tar_addr = (__force u64)otx2_get_regaddr(pfvf, NPA_LF_AURA_BATCH_FREE0);
532 /* LMTID is same as AURA Id */
533 val = (aura & 0x7FF) | BIT_ULL(63);
534 /* Set if [127:64] of last 128bit word has a valid pointer */
535 count_eot = (num_ptrs % 2) ? 0ULL : 1ULL;
536 /* Set AURA ID to free pointer */
537 ptrs[0] = (count_eot << 32) | (aura & 0xFFFFF);
538 /* Target address for LMTST flush tells HW how many 128bit
539 * words are valid from NPA_LF_AURA_BATCH_FREE0.
540 *
541 * tar_addr[6:4] is LMTST size-1 in units of 128b.
542 */
543 if (num_ptrs > 2) {
544 size = (sizeof(u64) * num_ptrs) / 16;
545 if (!count_eot)
546 size++;
547 tar_addr |= ((size - 1) & 0x7) << 4;
548 }
549 memcpy(lmt_addr, ptrs, sizeof(u64) * num_ptrs);
550 /* Perform LMTST flush */
551 cn10k_lmt_flush(val, tar_addr);
552 }
553

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip