Re: [PATCH for-next] ASoC: da7218: Drop CONFIG_OF ifdef

[Arnd Bergmann]

On Tue, Feb 2, 2021 at 7:36 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> This reverts commit a06cd8cf97a3 ("ASoC: da7218: skip of_device_id table
> when !CONFIG_OF") because we want to make of_match_device() stop using
> of_match_ptr() internally, confusing compilers and causing ifdef
> pollution.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> ---
>
> Please ack so Rob can take through DT tree.

Looks reasonable as a compile-time fix, though I'd remove the of_match_ptr()
usage as well in this case and just always reference the device id table.

Either way:

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>