Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd

From: Jason Gunthorpe
Date: Tue Feb 02 2021 - 14:13:33 EST

Next message: Ben Gardon: "[PATCH v2 18/28] KVM: x86/mmu: Use an rwlock for the x86 MMU"
Previous message: Kees Cook: "Re: [PATCH v1 1/1] Firstly, as Andy mentioned, this should be smp_rmb() instead of rmb(). considering that TSYNC is a cross-thread situation, and rmb() is a mandatory barrier which should not be used to control SMP effects, since mandatory barriers impose unnecessary overhead on both SMP and UP systems, as kernel Documentation said."
In reply to: Christoph Hellwig: "Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd"
Next in thread: Alex Williamson: "Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Feb 02, 2021 at 06:55:18PM +0000, Christoph Hellwig wrote:
> On Tue, Feb 02, 2021 at 02:50:17PM -0400, Jason Gunthorpe wrote:
> > For uAPI compatability vfio_pci.ko would need some
> > request_module()/symbol_get() trick to pass control over to the device
> > specific module.
>
> Err, don't go there.
>
> Please do the DRIVER_EXPLICIT_BIND_ONLY thing first, which avoids the
> need for such hacks.

Ah, right good point, we don't need to avoid loading the nvlink.ko if
loading it is harmless.

Jason

Next message: Ben Gardon: "[PATCH v2 18/28] KVM: x86/mmu: Use an rwlock for the x86 MMU"
Previous message: Kees Cook: "Re: [PATCH v1 1/1] Firstly, as Andy mentioned, this should be smp_rmb() instead of rmb(). considering that TSYNC is a cross-thread situation, and rmb() is a mandatory barrier which should not be used to control SMP effects, since mandatory barriers impose unnecessary overhead on both SMP and UP systems, as kernel Documentation said."
In reply to: Christoph Hellwig: "Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd"
Next in thread: Alex Williamson: "Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]