Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible strings

[Lars-Peter Clausen]

On 2/2/21 7:14 PM, Rob Herring wrote:
> The example uses 'adi,ad5686', but the schema fails to document it. Given
> the filename and there is a similar part AD5686, let's just add the
> compatible strings including the 'r' variant.

There are two variants of this chip. One with a SPI interface and one 
with a I2C interface. This binding document only describes the I2C 
variants. But the ad5686 is a SPI variant.

I think this is a typo and we should replace ad5686 with ad5696, 
including the document name.

> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
> Cc: Michael Auchter <michael.auchter@xxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index 8065228e5df8..190919291828 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -19,6 +19,8 @@ properties:
>         - adi,ad5338r
>         - adi,ad5671r
>         - adi,ad5675r
> +      - adi,ad5686
> +      - adi,ad5686r
>         - adi,ad5691r
>         - adi,ad5692r
>         - adi,ad5693