Re: [PATCH] mm/slub: embed __slab_alloc to its caller

From: Abel Wu
Date: Tue Feb 02 2021 - 20:43:38 EST


> On Feb 2, 2021, at 6:11 PM, Christoph Lameter <cl@xxxxxxxxx> wrote:
>
> On Tue, 2 Feb 2021, Abel Wu wrote:
>
>> Since slab_alloc_node() is the only caller of __slab_alloc(), embed
>> __slab_alloc() to its caller to save function call overhead. This
>> will also expand the caller's code block size a bit, but hackbench
>> tests on both host and guest didn't show a difference w/ or w/o
>> this patch.
>
> slab_alloc_node is an always_inline function. It is intentional that only
> the fast path was inlined and not the slow path.

Oh I got it. Thanks for your excellent explanation.

Best Regards,
Abel