RE: [PATCH V2 2/2] dt-bindings: power: bq27xxx: add bq78z10

[LI Qingwu]

Hello Krzysztof Kozlowski,

Thanks for input!

No comma before "and".  	>> I will delete in V3

What does it mean authentication? 	>> The gas gauge able to has a security key to seal and unseal access, to protect the design data, like design energy and capacity.

In the future, please send the bindings as first patch. The checkpatch should point this - did you run it?  >>yes, I run the checkpatch, I will reorder in V3.




Best Regards

**********************************************
Li Qingwu (Terry)
Senior Embedded Software Engineer 
Leica Geosystems(Shanghai)Co.,Limited
(Tel): +86 21 61061036
(FAX): +86 21 61061008
(Mobile): +86 187 0185 9600
E-mail: Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx
Http: www.leica-geosystems.com.cn
**********************************************

-----Original Message-----
From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> 
Sent: Tuesday, February 2, 2021 5:08 PM
To: LI Qingwu <qing-wu.li@xxxxxxxxxxxxxxxxxxxxxxx>
Cc: sre@xxxxxxxxxx; robh+dt@xxxxxxxxxx; dmurphy@xxxxxx; pali@xxxxxxxxxx; afd@xxxxxx; linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; TERTYCHNYI Grygorii <grygorii.tertychnyi@xxxxxxxxxxxxxxxxxxxx>; ZHIZHIKIN Andrey <andrey.zhizhikin@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH V2 2/2] dt-bindings: power: bq27xxx: add bq78z10

This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.


On Tue, Feb 02, 2021 at 08:48:58AM +0000, LI Qingwu wrote:
> Add bindings for TI BQ78Z100. An I2C interface gas gauge.
> It provides a fully integrated safety protection, and authentication 
> for 1 to 2-series cell Li-Ion and

No comma before "and".

What does it mean authentication?

In the future, please send the bindings as first patch. The checkpatch should point this - did you run it?

Best regards,
Krzysztof


> Li-Polymer battery packs.
>
> Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 +