RE: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

[Kostya Porotchkin]

Hu, Russel,

> -----Original Message-----
> From: Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>
> Sent: Wednesday, February 3, 2021 16:28
> To: Kostya Porotchkin <kostap@xxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> sebastian.hesselbarth@xxxxxxxxx; gregory.clement@xxxxxxxxxxx;
> andrew@xxxxxxx; mw@xxxxxxxxxxxx; jaz@xxxxxxxxxxxx; Nadav Haklai
> <nadavh@xxxxxxxxxxx>; Stefan Chulski <stefanc@xxxxxxxxxxx>; Ben Peled
> <bpeled@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for
> SDIO interafce
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, Feb 03, 2021 at 03:31:30PM +0200, kostap@xxxxxxxxxxx wrote:
> > From: Konstantin Porotchkin <kostap@xxxxxxxxxxx>
> >
> > Add SDIO mode pin control configration for CP0 on A8K DB.
> >
> > Signed-off-by: Konstantin Porotchkin <kostap@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
> > arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > index 293403a1a333..179218774ba9 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > @@ -47,6 +47,12 @@
> >  	cp0_pinctrl: pinctrl {
> >  		compatible = "marvell,armada-7k-pinctrl";
> >
> > +		sdhci_pins: sdhi-pins {
> 
> sdhi-pins ?
> 
[KP] You mean to replace the underline with dash?
Will do it in the next version, no problem.

> > +			marvell,pins = "mpp56", "mpp57", "mpp58",
> > +				       "mpp59", "mpp60", "mpp61", "mpp62";
> > +			marvell,function = "sdio";
> > +		};
> > +
> >  		nand_pins: nand-pins {
> >  			marvell,pins =
> >  			"mpp15", "mpp16", "mpp17", "mpp18", diff --git
> > a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > index ee67c70bf02e..64100ae204da 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > @@ -70,6 +70,12 @@
> >  &cp0_syscon0 {
> >  	cp0_pinctrl: pinctrl {
> >  		compatible = "marvell,armada-8k-cpm-pinctrl";
> > +
> > +		sdhci_pins: sdhi-pins {
> 
> sdhi-pins ?
> 
> > +			marvell,pins = "mpp56", "mpp57", "mpp58",
> > +				       "mpp59", "mpp60", "mpp61", "mpp62";
> > +			marvell,function = "sdio";
> > +		};
> >  	};
> >  };
> >
> > --
> > 2.17.1
> >
> >
> 
> --
> RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.armlinux.org.uk_developer_patches_&d=DwIBAg&c=nKjWec2b6R0
> mOyPaz7xtfQ&r=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=wUA0mnqioCngi
> HLZcn2iOBuiWLQtawWb1yfozx_80C4&s=_yolpLSRiJi4CnA-
> iEzpbF5r77VBdLcM6pouXxTdupk&e=
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!