Re: [PATCH v3 01/11] docs: ioctl-number.rst: reserve IIO subsystem ioctl() space

From: Jonathan Cameron
Date: Thu Feb 04 2021 - 12:13:19 EST


On Mon, 1 Feb 2021 16:50:55 +0200
Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:

> Currently, only the 'i' 0x90 ioctl() actually exists and is defined in
> 'uapi/linux/iio/events.h'.
>
> It's the IIO_GET_EVENT_FD_IOCTL, which is used to retrieve and FD for
> reading events from an IIO device.
> We will want to add more ioct() numbers, so with this change the 'i'
> 0x90-0x9F space is reserved for IIO ioctl() calls.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
Hi Alex,

Thanks for tidying this up. My bad from a long time ago to not register
this at the time.

> ---
> Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index a4c75a28c839..9ebde26b7e32 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -245,6 +245,7 @@ Code Seq# Include File Comments
> 'i' 00-3F linux/i2o-dev.h conflict!
> 'i' 0B-1F linux/ipmi.h conflict!
> 'i' 80-8F linux/i8k.h
> +'i' 90-9F `uapi/linux/iio/*.h` IIO

I think the uapi/ bit is effectively implicit. I checked a few of them and the
definitions are in uapi/linux/

> 'j' 00-3F linux/joystick.h
> 'k' 00-0F linux/spi/spidev.h conflict!
> 'k' 00-05 video/kyro.h conflict!