Re: [PATCH v2] kdb: Refactor env variables get/set code

[Doug Anderson]

Hi,

On Thu, Feb 4, 2021 at 2:14 AM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
>
> Add two new kdb environment access methods as kdb_setenv() and
> kdb_printenv() in order to abstract out environment access code
> from kdb command functions.
>
> Also, replace (char *)0 with NULL as an initializer for environment
> variables array.
>
> Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
> ---
>
> Changes in v2:
> - Get rid of code motion to separate kdb_env.c file.
> - Replace (char *)0 with NULL.
> - Use kernel-doc style function comments.
> - s/kdb_prienv/kdb_printenv/
>
>  kernel/debug/kdb/kdb_main.c | 166 +++++++++++++++++++++++++-------------------
>  1 file changed, 93 insertions(+), 73 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>