Re: [PATCH 2/2] crypto: marvell - fix ethernet driver dependency

From: Herbert Xu
Date: Thu Feb 04 2021 - 14:49:08 EST


On Thu, Feb 04, 2021 at 04:42:16PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The OcteonTX2 CPT driver force-enables the OCTEONTX2_MBOX symbol,
> which fails when network drivers are disabled globally
>
> WARNING: unmet direct dependencies detected for OCTEONTX2_MBOX
> Depends on [n]: NETDEVICES [=n] && ETHERNET [=n] && NET_VENDOR_MARVELL [=n]
> Selected by [y]:
> - CRYPTO_DEV_OCTEONTX2_CPT [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && (ARM64 [=y] || COMPILE_TEST [=y]) && PCI_MSI [=y] && 64BIT [=y] && CRYPTO_LIB_AES [=y]
>
> The crypto driver actually fails to link without the ethernet side,
> so this is a hard dependency. Change the 'select' into 'depends on'
> to make it build reliably without warnings.
>
> Fixes: 5e8ce8334734 ("crypto: marvell - add Marvell OcteonTX2 CPT PF driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/crypto/marvell/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

There is already a patch for this:

https://patchwork.kernel.org/project/linux-crypto/patch/20210129054856.GA20020@xxxxxxxxxxxxxxxxxxx/

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt