Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

[Ben Widawsky]

On 21-02-04 21:53:29, John Groves (jgroves) wrote:
>    Micron Confidential
> 
> 
> 
>    From: Dan Williams <dan.j.williams@xxxxxxxxx>
>    Date: Monday, February 1, 2021 at 1:28 PM
>    To: Ben Widawsky <ben.widawsky@xxxxxxxxx>
>    Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,
>    linux-cxl@xxxxxxxxxxxxxxx <linux-cxl@xxxxxxxxxxxxxxx>, Linux ACPI
>    <linux-acpi@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List
>    <linux-kernel@xxxxxxxxxxxxxxx>, linux-nvdimm
>    <linux-nvdimm@xxxxxxxxxxxx>, Linux PCI <linux-pci@xxxxxxxxxxxxxxx>,
>    Bjorn Helgaas <helgaas@xxxxxxxxxx>, Chris Browy
>    <cbrowy@xxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ira
>    Weiny <ira.weiny@xxxxxxxxx>, Jon Masters <jcm@xxxxxxxxxxxxxx>, Jonathan
>    Cameron <Jonathan.Cameron@xxxxxxxxxx>, Rafael Wysocki
>    <rafael.j.wysocki@xxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>,
>    Vishal Verma <vishal.l.verma@xxxxxxxxx>, daniel.lll@xxxxxxxxxxxxxxx
>    <daniel.lll@xxxxxxxxxxxxxxx>, John Groves (jgroves)
>    <jgroves@xxxxxxxxxx>, Kelley, Sean V <sean.v.kelley@xxxxxxxxx>
>    Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox
> 
>    CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless
>    you recognize the sender and were expecting this message.
>    On Mon, Feb 1, 2021 at 11:13 AM Ben Widawsky <ben.widawsky@xxxxxxxxx>
>    wrote:
>    >
>    > On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote:
>    > > > +#define
>    cxl_doorbell_busy(cxlm)
>    \
>    > > > +   (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET)
>    &                    \
>    > > > +    CXLDEV_MB_CTRL_DOORBELL)
>    > > > +
>    > > > +#define CXL_MAILBOX_TIMEOUT_US 2000
>    > >
>    > > You been using the spec for the values. Is that number also from it
>    ?
>    > >
>    >
>    > Yes it is. I'll add a comment with the spec reference.
> 
> 
> 
>    From section 8.2.8.4 in the CXL 2.0 spec: “The mailbox command timeout
>    is 2 seconds.”  So this should be:
> 
> 
>    #define CXL_MAILBOX_TIMEOUT_US 2000000
> 
> 
>    …right? 2000us is 2ms…
> 
> 

Thanks. This was caught already in earlier review by David Rientjes
<rientjes@xxxxxxxxxx>

It's renamed CXL_MAILBOX_TIMEOUT_MS 2000