Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT
From: Pavel Machek
Date: Fri Feb 05 2021 - 05:27:17 EST
Hi!
> > > patternProperties:
> > > "(^led-[0-9a-f]$|led)":
> > > @@ -99,6 +104,7 @@ examples:
> > > reg = <0x1>;
> > > color = <LED_COLOR_ID_RGB>;
> > > function = LED_FUNCTION_CHARGING;
> > > + default-intensity = <100 0 0>;
> > >
> > > led-0 {
> > > color = <LED_COLOR_ID_RED>;
> >
> > Should this go to leds-class-multicolor.yaml ?
>
> I think then all drivers should support it, but I cannot change all drivers.
> So I would only leave it in there.
It really should be in common binding, and no, that does not mean you
need to change all the drivers.
Plus there's at most two of them at the moment.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: Digital signature