Re: [patch 11/12] softirq: Allow inlining do_softirq_own_stack()
From: Thomas Gleixner
Date: Fri Feb 05 2021 - 06:42:07 EST
On Fri, Feb 05 2021 at 18:14, Lai Jiangshan wrote:
> On Fri, Feb 5, 2021 at 10:04 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> static inline void do_softirq_own_stack(void)
>> {
>
> Hello
>
> This patch and the next patch have three "#if[n]def" with
> __ARCH_HAS_DO_SOFTIRQ_INLINE and this one is nested in
> __ARCH_HAS_DO_SOFTIRQ.
>
> I wonder if we can use __ARCH_HAS_DO_SOFTIRQ only.
>
> For example, we can move "void do_softirq_own_stack(void);" to around
> the code where __ARCH_HAS_DO_SOFTIRQ are defined in very ARCHs.
> (And for x86, do_softirq_own_stack() is a macro instead of function
> declaration as next patch shows)
We can do that as well. No strong preference.
Thanks,
tglx