Re: [PATCH v6 0/7] common SVDM version and VDO from dt
From: Heikki Krogerus
Date: Fri Feb 05 2021 - 06:49:15 EST
On Fri, Feb 05, 2021 at 11:34:08AM +0800, Kyle Tso wrote:
> v5 is here:
> https://patchwork.kernel.org/project/linux-usb/cover/20210202161733.932215-1-kyletso@xxxxxxxxxx/
>
> Changes since v5:
> =================
> usb: typec: Manage SVDM version
> - !! most changes are from Heikki
> - location of the negotiated SVDM version is changed. Now the variable
> resides in typec_partner
> - The setter and getter functions were modified according to the above
> changes
> - the default SVDM version is stored upon calling to
> typec_register_partner
>
> usb: pd: Make SVDM Version configurable in VDM header
> - no change
>
> usb: typec: tcpm: Determine common SVDM Version
> - follow the changes of "usb: typec: Manage SVDM version"
> - remove the "reset to default". Now the default SVDM version will be
> set when calling to typec_register_partner
>
> usb: typec: ucsi: Determine common SVDM Version
> - follow the changes of "usb: typec: Manage SVDM version"
> - remove the "reset to default". Now the default SVDM version will be
> set when calling to typec_register_partner
>
> usb: typec: displayport: Fill the negotiated SVDM Version in the header
> - follow the changes of "usb: typec: Manage SVDM version"
>
> dt-bindings: connector: Add SVDM VDO properties
> - no change
>
> usb: typec: tcpm: Get Sink VDO from fwnode
> - no change
>
> Kyle Tso (7):
> usb: typec: Manage SVDM version
> usb: pd: Make SVDM Version configurable in VDM header
> usb: typec: tcpm: Determine common SVDM Version
> usb: typec: ucsi: Determine common SVDM Version
> usb: typec: displayport: Fill the negotiated SVDM Version in the header
> dt-bindings: connector: Add SVDM VDO properties
> usb: typec: tcpm: Get Sink VDO from fwnode
These are OK by me, but I think it would be great if Guenter could
give them the once-over, as usual. I hope he has time. FWIW, for all
of these:
Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
thanks,
--
heikki