Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

From: Sergej Bauer
Date: Fri Feb 05 2021 - 17:32:57 EST


On Friday, February 5, 2021 5:07:22 PM MSK you wrote:
> Hi Sergej,
>
> On Fri, Feb 5, 2021 at 7:44 AM Sergej Bauer <sbauer@xxxxxxxxxxx> wrote:
> > Hi Sven
> > I can confirm great stability improvement after your patch
> > "lan743x: boost performance on cpu archs w/o dma cache snooping".
> >
> > Test machine is Intel Pentium G4560 3.50GHz
> > lan743x with rejected virtual phy 'inside'
>
> Interesting, so the speed boost patch seems to improve things even on
> Intel...
>
> Would you be able to apply and test the multi-buffer patch as well?
> To do that, you can simply apply patches [2/6] and [3/6] on top of
> what you already have.
>

Hi Sven
Tests after applying patches [2/6] and [3/6] are:
$ ifmtu eth7 500
$ sudo test_ber -l eth7 -c 1000 -n 1000000 -f500 --no-conf
...
number of sent packets = 1000000
number of received packets = 713288
number of lost packets = 286712
number of out of order packets = 0
number of bit errors = 0
total errors detected = 286712
bit error rate = 0.286712
average speed: 427.8043 Mbit/s

$ ifmtu eth7 1500
$ sudo test_ber -l eth7 -c 1000 -n 1000000 -f500 --no-conf
...
number of sent packets = 1000000
number of received packets = 707869
number of lost packets = 292131
number of out of order packets = 0
number of bit errors = 0
total errors detected = 292131
bit error rate = 0.292131
average speed: 431.0163 Mbit/s

$ sudo test_ber -l eth7 -c 1000 -n 1000000 -f1500 --no-conf
...
number of sent packets = 1000000
number of received packets = 1000000
number of lost packets = 0
number of out of order packets = 0
number of bit errors = 0
total errors detected = 0
bit error rate = 0
average speed: 646.4932 Mbit/s

> Keeping in mind that Bryan has identified an issue with the above
> patch, which will get fixed in v2. So YMMV.
I'll perform tests with v2 as well.