Re: [PATCH v2] drm/qxl: do not run release if qxl failed to init

From: Tong Zhang
Date: Fri Feb 05 2021 - 18:41:45 EST


On Feb 5, 2021, at 2:43 AM, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>
> On Thu, Feb 04, 2021 at 11:30:50AM -0500, Tong Zhang wrote:
>> if qxl_device_init() fail, drm device will not be registered,
>> in this case, do not run qxl_drm_release()
>
> How do you trigger this?
>

This can be triggered by changing the QXL VGA rom magic value.

In the QEMU source code ./hw/display/qxl.c
or change the QXL_ROM_MAGIC in spice header file

- Tong

> take care,
> Gerd
>